cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbel...@apache.org
Subject svn commit: r919096 - /incubator/cassandra/branches/cassandra-0.6/src/java/org/apache/cassandra/thrift/CassandraDaemon.java
Date Thu, 04 Mar 2010 17:54:39 GMT
Author: jbellis
Date: Thu Mar  4 17:54:39 2010
New Revision: 919096

URL: http://svn.apache.org/viewvc?rev=919096&view=rev
Log:
change thrift bind message to INFO, and add jsvc comments.  patch by jbellis; reviewed by
eevans for CASSANDRA-849

Modified:
    incubator/cassandra/branches/cassandra-0.6/src/java/org/apache/cassandra/thrift/CassandraDaemon.java

Modified: incubator/cassandra/branches/cassandra-0.6/src/java/org/apache/cassandra/thrift/CassandraDaemon.java
URL: http://svn.apache.org/viewvc/incubator/cassandra/branches/cassandra-0.6/src/java/org/apache/cassandra/thrift/CassandraDaemon.java?rev=919096&r1=919095&r2=919096&view=diff
==============================================================================
--- incubator/cassandra/branches/cassandra-0.6/src/java/org/apache/cassandra/thrift/CassandraDaemon.java
(original)
+++ incubator/cassandra/branches/cassandra-0.6/src/java/org/apache/cassandra/thrift/CassandraDaemon.java
Thu Mar  4 17:54:39 2010
@@ -105,8 +105,7 @@
         // Transport
         TServerSocket tServerSocket = new TServerSocket(new InetSocketAddress(listenAddr,
listenPort));
         
-        if (logger.isDebugEnabled())
-            logger.debug(String.format("Binding thrift service to %s:%s", listenAddr, listenPort));
+        logger.info(String.format("Binding thrift service to %s:%s", listenAddr, listenPort));
 
         // Protocol factory
         TProtocolFactory tProtocolFactory = new TBinaryProtocol.Factory();
@@ -153,6 +152,8 @@
     /** hook for JSVC */
     public void stop()
     {
+        // this doesn't entirely shut down Cassandra, just the Thrift server.
+        // jsvc takes care of taking the rest down
         logger.info("Cassandra shutting down...");
         serverEngine.stop();
     }
@@ -160,7 +161,9 @@
     
     /** hook for JSVC */
     public void destroy()
-    {        
+    {
+        // this is supposed to "destroy any object created in init", but
+        // StorageService et al. are crash-only, so we no-op here.
     }
     
     public static void main(String[] args)



Mime
View raw message