cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stu Hood (JIRA)" <>
Subject [jira] Commented: (CASSANDRA-751) refactor streaming
Date Sat, 30 Jan 2010 23:59:34 GMT


Stu Hood commented on CASSANDRA-751:

This is a huge improvement... the 'streaming' package is much more autonomous now.

1. This seems like a good opportunity to fix the line endings in all the files that moved:
lots of carriage returns scattered about
2. StreamOut.RING_DELAY should move elsewhere
3. InitiatedFile isn't sticking with me... the transfer hasn't always been initialized when
that object is used
4. dht.StreamInitiateMessage escaped the migration. Perhaps -> streaming.InitiateMessage
5. Since streaming is so well encapsulated now, we could probably enforce it by making a bunch
of its classes package-protected: all of Stream(Out|In)Manager,Stream*(Verb|Message) for instance.
The only public interfaces need to be StreamIn and StreamOut.

Thanks a bunch!

> refactor streaming
> ------------------
>                 Key: CASSANDRA-751
>                 URL:
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.6
>         Attachments: 0001-centralize-streaming-code-in-org.apache.cassandra.stre.txt,
0002-split-Streaming-into-StreamOut-and-StreamIn-clean-up-S.txt, 0003-rename-StreamContextManager-StreamInManager-StreamMang.txt,
0004-r-m-unneeded-StreamStatusMessage-wrapper.txt, 0005-extract-SIM.StreamStatus-to-CompletedFileStatus.txt

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message