cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Hodges (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-734) Table.open has a broken lock in it
Date Sun, 24 Jan 2010 20:44:17 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804296#action_12804296
] 

Jeff Hodges commented on CASSANDRA-734:
---------------------------------------

bq. Not if we do the initTable work, and then later turn it in a NBHM. With initTable in place,
and we go to update a Table, we would only have to do a put without the conditional instantiation.

(And it seems to me that if it's possible to construct a Table in more than one thread in
our solution to CASSANDRA-44, we're very likely solving CASSANDRA-44 wrong.)

> Table.open has a broken lock in it
> ----------------------------------
>
>                 Key: CASSANDRA-734
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-734
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.5
>            Reporter: Jeff Hodges
>            Assignee: Jeff Hodges
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: broken_lock_in_table_open.patch
>
>
> Table.open's lock is used around the Map#put method call but not the #get. This makes
it a source of spurious bugs. The attached patch synchronizes the entire Table.open method
and removes the unused createLock static.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message