Mailing-List: contact cassandra-commits-help@incubator.apache.org;
 run by ezmlm
Precedence: bulk
Reply-To: cassandra-dev@incubator.apache.org
Message-ID: <778890408.1260383298621.JavaMail.jira@brutus>
Date: Wed, 9 Dec 2009 18:28:18 +0000 (UTC)
From: "Stu Hood (JIRA)" <jira@apache.org>
To: cassandra-commits@incubator.apache.org
Subject: [jira] Commented: (CASSANDRA-611) Fix Findbugs: Replace keySet w
 entrySet
In-Reply-To: <97025595.1260294438075.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788212#action_12788212 ] 

Stu Hood commented on CASSANDRA-611:
------------------------------------

I just noticed that this report missed the most critical of all our abuses of keySet(): calling ColumnFamily.getSortedValues(), and then calling getColumn(name) on another CF. For two sorted lists, we should iterate in parallel.

> Fix Findbugs: Replace keySet w entrySet
> ---------------------------------------
>
>                 Key: CASSANDRA-611
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-611
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stu Hood
>         Attachments: findbugs-keyset-w-entryset.txt
>
>
> A lot of places in the codebase, we iterate over the  keySet() of a Map, and call get() for each key. For a HashMap, this is still O(N), but when you are dealing with a SortedMap, this is O(NlogN). The list of occurences are attached.
> Fixing this issue should give us a general (minor?) performance boost.
> In order to find unused method parameters for CASSANDRA-608, I ran FindBugs against Cassandra, and found a few interesting issues we ought to explore (but not the unused method params, oi.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.