Return-Path: Delivered-To: apmail-incubator-cassandra-commits-archive@minotaur.apache.org Received: (qmail 66999 invoked from network); 8 Dec 2009 18:54:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 8 Dec 2009 18:54:41 -0000 Received: (qmail 86455 invoked by uid 500); 8 Dec 2009 18:54:41 -0000 Delivered-To: apmail-incubator-cassandra-commits-archive@incubator.apache.org Received: (qmail 86424 invoked by uid 500); 8 Dec 2009 18:54:41 -0000 Mailing-List: contact cassandra-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cassandra-dev@incubator.apache.org Delivered-To: mailing list cassandra-commits@incubator.apache.org Received: (qmail 86345 invoked by uid 99); 8 Dec 2009 18:54:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Dec 2009 18:54:41 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Dec 2009 18:54:39 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 24BC729A0012 for ; Tue, 8 Dec 2009 10:54:18 -0800 (PST) Message-ID: <1965187224.1260298458148.JavaMail.jira@brutus> Date: Tue, 8 Dec 2009 18:54:18 +0000 (UTC) From: "Stu Hood (JIRA)" To: cassandra-commits@incubator.apache.org Subject: [jira] Updated: (CASSANDRA-612) Fix Findbugs: Condition misuse In-Reply-To: <94629494.1260298458074.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stu Hood updated CASSANDRA-612: ------------------------------- Attachment: await.txt > Fix Findbugs: Condition misuse > ------------------------------ > > Key: CASSANDRA-612 > URL: https://issues.apache.org/jira/browse/CASSANDRA-612 > Project: Cassandra > Issue Type: Bug > Reporter: Stu Hood > Attachments: await.txt > > > We frequently misuse Condition objects, although there is no guarantee that all of the uses are abuses. > On the other hand, findbugs did find two issues that are likely to be bugs: not checking the return value of await(timeout), and calling wait() rather than await() on a Condition. See the attached. > In order to find unused method parameters for CASSANDRA-608, I ran FindBugs against Cassandra, and found a few interesting issues we ought to explore (but not the unused method params, oi.) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.