cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <>
Subject [jira] Commented: (CASSANDRA-547) authentication and authorization functions (stage 1)
Date Wed, 30 Dec 2009 17:05:23 GMT


Jonathan Ellis commented on CASSANDRA-547:

thanks, 34k is much easier to review than 600k.

style note: we start interface names with I, as in IAuthenticationBackend

I still see gratuitous renaming of variables, e.g. consistency_level to consistencyLevel (don't
do that, we use underscores for thrift variable names on purpose)

upgrading thrift is still assumed (by the changing to CL enum at the least); this does not
build with the current thrift we are using.  if you decide that finishing the upgrade is easier
than finishing the downgrade, please note that "separate patches" means one builds on the
other, not one is a superset of the other.  I really do think using a tool that can operate
on sets of patches will make your life easier here, e.g. quilt or hg if you have something
against git. :)

Is there a backend that is more than a no-op?  we don't commit refactorings with no raison
d'etre, even to trunk.

the keyspace argument to login is not passed to the authenticator, so either it is redundant
or there is a bug there

I don't see any code that verifies that login was successfully called before allowing other
methods to be called

> authentication and authorization functions (stage 1)
> ----------------------------------------------------
>                 Key: CASSANDRA-547
>                 URL:
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Ted Zlatanov
>            Assignee: Ted Zlatanov
>         Attachments: CASSANDRA-547-auth.patch, CASSANDRA-547-thrift.patch, libthrift-r893324.jar
> Add functions to login() and setKeyspace().  Check against authentication+authorization
backends whether those calls should succeed or fail.
> Create file-based and LDAP backends to implement authentication and authorization.
> Create AllowAll backend to allow all access.
> Add configuration stanza to specify the auth backend.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message