cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-612) Fix Findbugs: Condition misuse
Date Tue, 08 Dec 2009 19:39:18 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787691#action_12787691
] 

Jonathan Ellis commented on CASSANDRA-612:
------------------------------------------

note that most (all?) of our Condition objects are instances of SimpleCondition, which implements
await in terms of wait (and fixes several problems with the Conditions created by lock objects,
which may also be findbugs false positives)

> Fix Findbugs: Condition misuse
> ------------------------------
>
>                 Key: CASSANDRA-612
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-612
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stu Hood
>         Attachments: await.txt
>
>
> We frequently misuse Condition objects, although there is no guarantee that all of the
uses are abuses.
> On the other hand, findbugs did find two issues that are likely to be bugs: not checking
the return value of await(timeout), and calling wait() rather than await() on a Condition.
See the attached.
> In order to find unused method parameters for CASSANDRA-608, I ran FindBugs against Cassandra,
and found a few interesting issues we ought to explore (but not the unused method params,
oi.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message