cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <>
Subject [jira] Commented: (CASSANDRA-408) Pool BufferedRandomAccessFile objects used by sstable reads
Date Mon, 28 Dec 2009 15:07:29 GMT


Jonathan Ellis commented on CASSANDRA-408:

Using mmapped files instead should be both simpler and higher-performance.  (_Should_.  Testing

We already have most of the plumbing needed w/ our phantomreferences on sstablereaders to
be able to wait for GC of the MappedByteBuffer before deleting a compacted sstable, which
is the major problem w/ the mmap approach.

> Pool BufferedRandomAccessFile objects used by sstable reads
> -----------------------------------------------------------
>                 Key: CASSANDRA-408
>                 URL:
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Chris Goffinet
>             Fix For: 0.9
>         Attachments: 408.patch, commons-pool-1.5.2.jar
> not only does BRAF per op do a whole lot of extra fopens, but the buffering actually
makes it _more_ expensive to set up since on the jvm all primitive arrays are initialized
to zero.
> this adds a simple read test to; I'm seeing about a 10% increase in throughput
which is worth 200loc imo.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message