Mailing-List: contact cassandra-commits-help@incubator.apache.org;
 run by ezmlm
Precedence: bulk
Reply-To: cassandra-dev@incubator.apache.org
Message-ID: <703821268.1257356732786.JavaMail.jira@brutus>
Date: Wed, 4 Nov 2009 17:45:32 +0000 (UTC)
From: "Gary Dusbabek (JIRA)" <jira@apache.org>
To: cassandra-commits@incubator.apache.org
Subject: [jira] Updated: (CASSANDRA-488) TcpConnectionManager only ever has
 one connection
In-Reply-To: <1885041595.1255542391414.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CASSANDRA-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-488:
------------------------------------

    Attachment: cassandra-488-v4.patch

converted lock to synchronized.

> TcpConnectionManager only ever has one connection
> -------------------------------------------------
>
>                 Key: CASSANDRA-488
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-488
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.5
>
>         Attachments: 488-v3.patch, cassandra-488-v1.patch, cassandra-488-v2.patch, cassandra-488-v4.patch
>
>
> from irc:
> jbellis: am i missing something?  it looks like TcpConnectionManager.allConnections_ will only ever contain a single TcpConnection, since before adding any connection it checks contains() first, which relies on TcpConn.equals, which reports that any TcpConns w/ same local & remote endpoints are equal
> junrao: yes, TcpConnectionManager.allConnections_ can have no more than 1 element.
> jbellis: that might explain why it's so easy to swamp things and start getting timeouts -- if all your connections are full of command data, "success" replies will have to wait for those to drain out first before being sent
> IMO the Right Design is one connection for commands, one connection for acks/replies, rather than a single pool of connections for everything.  that way a connection from A -> B "full" of outgoing commands can't block replies from A -> B acking commands that came the other way.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.