cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-498) Replace EndPoint class with InetAddress
Date Thu, 22 Oct 2009 12:35:59 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768663#action_12768663
] 

Hudson commented on CASSANDRA-498:
----------------------------------

Integrated in Cassandra #235 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/235/])
    convert EndPoint to InetAddress (removes MembershipCleaner, the code to drop a node from
the cluster entirely.  we're probably going to want to resurrect that at some point)
patch by jbellis; reviewed by Brandon Williams for 
r/m uses of EndPoint(port) constructor; rename EndPoint methods to make porting easier; r/m
gratuitous uses of getHost
patch by jbellis; reviewed by Brandon Williams for 
r/m unused "listening" distinction in TcpConnection
patch by jbellis; reviewed by Brandon Williams for 


> Replace EndPoint class with InetAddress
> ---------------------------------------
>
>                 Key: CASSANDRA-498
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-498
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.5
>
>         Attachments: 0001-CASSANDRA-498-r-m-unused-listening-distinction-in-Tc.txt, 0002-r-m-uses-of-EndPoint-port-constructor-rename-EndPoin.txt,
0003-convert-EndPoint-to-InetAddress-removes-MembershipCle.txt
>
>
> EndPoint is problematic because there are two for each node: one for the TCP port (used
for all data-related traffic), and one for UDP (for gossip).  Often you will have a collection
of one type of EndPoint, and want to look it up by the other type; this gives rise to abominations
such as retrofitPorts and hard-to-find bugs.
> Replacing EndPoint with the standard and port-less InetAddress fixes these problems.
 (We push the actual tcp/udp ports into TcpConnection / UdpConnection, where they belong.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message