cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brandon Williams (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-498) Replace EndPoint class with InetAddress
Date Wed, 21 Oct 2009 18:21:59 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768356#action_12768356
] 

Brandon Williams commented on CASSANDRA-498:
--------------------------------------------

+1, tests pass and this also allows me to specify a hostname as a seed.

> Replace EndPoint class with InetAddress
> ---------------------------------------
>
>                 Key: CASSANDRA-498
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-498
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.5
>
>         Attachments: 0001-CASSANDRA-498-r-m-unused-listening-distinction-in-Tc.txt, 0002-r-m-uses-of-EndPoint-port-constructor-rename-EndPoin.txt,
0003-convert-EndPoint-to-InetAddress-removes-MembershipCle.txt
>
>
> EndPoint is problematic because there are two for each node: one for the TCP port (used
for all data-related traffic), and one for UDP (for gossip).  Often you will have a collection
of one type of EndPoint, and want to look it up by the other type; this gives rise to abominations
such as retrofitPorts and hard-to-find bugs.
> Replacing EndPoint with the standard and port-less InetAddress fixes these problems.
 (We push the actual tcp/udp ports into TcpConnection / UdpConnection, where they belong.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message