cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jun Rao (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-414) remove sstableLock
Date Fri, 11 Sep 2009 03:28:03 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753966#action_12753966
] 

Jun Rao commented on CASSANDRA-414:
-----------------------------------

Maybe I don''t understand how PhantomReference works, but the code in SSTableReader dealing
with finalizerQueue doesn't look right to me. What gets enqueued in finalizerQueue is SSTR.
It doesn't seem like that you can cast it directly to FileDeletingReference. It seems to me
that you have to maintain a map btw SSTR and FileDeletingReference. Every time you dequeue
an item from finalizerQueue, you can lookup the map to find the corresponding FileDeletingReference.

> remove sstableLock
> ------------------
>
>                 Key: CASSANDRA-414
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-414
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.5
>
>         Attachments: 0001-CASSANDRA-414-combine-addToList-and-storeLocation-ren.txt,
0001-CASSANDRA-414-combine-addToList-and-storeLocation-ren.txt, 0001-CASSANDRA-414-combine-addToList-and-storeLocation-ren.txt,
0002-convert-ssTables_-to-a-Set-since-the-filename-is-enca.txt, 0002-remove-sstableLock.-re-order-a-few-ops-so-that-we-can.txt,
0002-remove-sstableLock.-re-order-a-few-ops-so-that-we-can.txt, 0003-Replace-sstableLock-with-SSTableTracker-which-perform.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message