Mailing-List: contact cassandra-commits-help@incubator.apache.org;
 run by ezmlm
Precedence: bulk
Reply-To: cassandra-dev@incubator.apache.org
Message-ID: <691903325.1251130979291.JavaMail.jira@brutus>
Date: Mon, 24 Aug 2009 09:22:59 -0700 (PDT)
From: "Jonathan Ellis (JIRA)" <jira@apache.org>
To: cassandra-commits@incubator.apache.org
Subject: [jira] Commented: (CASSANDRA-197) Expose ring map to client for
 more direct access
In-Reply-To: <1983416145.1243011886030.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746940#action_12746940 ] 

Jonathan Ellis commented on CASSANDRA-197:
------------------------------------------

+1 on the approach in general.  some nits:

        partitioner_ = DatabaseDescriptor.getPartitioner();

inline this in declaration

        Map<Token,EndPoint>endpointMap

spacing

        for (String seed : seeds_)

shouldn't this break after getting an answer?  shouldn't need to contact all seeds each time

    private void retrofitPorts(EndPoint endPoints[])

this should be encapsulated in tokenmetadata (yeah, I know it's that way in existing code) -- have a cloneControl and cloneStorage method instead of forcing consumers of the api to know that they need to do this "magic" fixup later.

> Expose ring map to client for more direct access
> ------------------------------------------------
>
>                 Key: CASSANDRA-197
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-197
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>         Attachments: flexjson.jar, issue197.patchv1, patch197.v2
>
>
> For certain applications, it would be nice if a read is sent to a node that owns the data locally. This saves an extra network hop. To do that, a client will need to cache the ring map and use it to figure out the nodes owning a row.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.