cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill de hOra (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (CASSANDRA-335) Temp SSTable Generation increases by two, instead of one
Date Mon, 03 Aug 2009 19:31:15 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738515#action_12738515
] 

Bill de hOra edited comment on CASSANDRA-335 at 8/3/09 12:30 PM:
-----------------------------------------------------------------

"IIRC this is actually done on purpose"

and the comment is above one of the places where it's called (L359 in ColumnFamilyStore).
Is calling fileIndexGenerator_ twice supposed to be an atomic op, or can it be interleaved?


      was (Author: dehora):
    {quote}IIRC this is actually done on purpose{quote}

and the comment is above one of the places where it's called (L359 in ColumnFamilyStore).
Is calling fileIndexGenerator_ twice supposed to be an atomic op, or can it be interleaved?

  
> Temp SSTable Generation increases by two, instead of one
> --------------------------------------------------------
>
>                 Key: CASSANDRA-335
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-335
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.4
>            Reporter: Chris Goffinet
>            Priority: Trivial
>             Fix For: 0.4
>
>
> String getTempSSTableFileName()
>     {
>         fileIndexGenerator_.incrementAndGet();
>         return String.format("%s-%s-%s-Data.db",
>                              columnFamily_, SSTable.TEMPFILE_MARKER, fileIndexGenerator_.incrementAndGet());
>     }
> It's incrementing twice. Remove the first one since the return is already calling it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message