cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <>
Subject [jira] Commented: (CASSANDRA-332) Clean up SSTableSliceIterator to not echo data around DataOutput/Inputs
Date Thu, 06 Aug 2009 23:19:14 GMT


Jonathan Ellis commented on CASSANDRA-332:

like I said, for the range scan check you will write

if (finish < indexes[0].firstcolumn || start > indexes[-1].lastcolumn) 

so you need both firstcolumn and lastcolumn; desc scan also needs both.

also in patch 4 for CASSANDRA-351 I added

                if (, indexInfo.firstName) < 0)

as a similar "see if we can skip the actual scan" check.

(this won't get hit as often b/c of the bloom filter...  of course we haven't really decided
if that's going to stay or not yet.  that's CASSANDRA-325 for those not following -commits.)

> Clean up SSTableSliceIterator to not echo data around DataOutput/Inputs
> -----------------------------------------------------------------------
>                 Key: CASSANDRA-332
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.4
>         Attachments: 0001-CASSANDRA-332-add-test-for-multi-block-reversal.txt, 0002-don-t-serialize-unused-column-count-into-column-index.txt,
0003-always-write-indexes-for-at-least-first-and-last-colum.txt, 0004-move-comparator-out-of-IndexInfo.txt,
0005-avoid-copying-variables-to-ColumnGroupReader-that-it-c.txt, 0006-final-cleanup-of-SSTableSliceIterator-now-with-less-u.txt
> use CFSerializer.deserializeEmpty and then read the columns as necessary, similar to
what was done for SSTableNamesIterator

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message