cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Updated: (CASSANDRA-338) Fix low-hanging scoping and other issues picked up by findbugs
Date Wed, 05 Aug 2009 13:14:14 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Ellis updated CASSANDRA-338:
-------------------------------------

    Attachment: findbugs-2nd-addendum.diff

addendup to patch 2:

instead of adding hashcode to classes that override equals unnecessarily, r/m the equals method.

instead of adding null checks to variables that Should Never Be Null, add assert != null.

look ok?

> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-338
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-338
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.4
>            Reporter: Michael Greene
>            Priority: Trivial
>             Fix For: 0.4
>
>         Attachments: cassandra-findbugs-1.diff, cassandra-findbugs-2.diff, findbugs-2nd-addendum.diff,
findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk.  Many of these are invalid, but many
are genuine.  This issue will involve fixing the genuine ones that are fixable in time for
0.4.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message