cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-338) Fix low-hanging scoping and other issues picked up by findbugs
Date Fri, 07 Aug 2009 23:29:14 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740787#action_12740787
] 

Jonathan Ellis commented on CASSANDRA-338:
------------------------------------------

applied (minus the unit tests -- the effort is appreciated, but it doesn't actually exercise
any code in StorageService), thanks!

> I'm wondering if this hasn't blown up to date whether the path ever gets executed? 

It isn't.  Sandeep, is that code fragment (StorageService.forceHandoff) going to be useful
at all for CASSANDRA-195?  If not let's nuke it.

> Fix low-hanging scoping and other issues picked up by findbugs
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-338
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-338
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.4
>            Reporter: Michael Greene
>            Priority: Trivial
>             Fix For: 0.4
>
>         Attachments: CASSANDRA-338-CCE.diff, cassandra-findbugs-1.diff, cassandra-findbugs-2.diff,
findbugs-2nd-addendum.diff, findbugs-2ndset-1.diff
>
>
> Findbugs currently reports 266 bugs against trunk.  Many of these are invalid, but many
are genuine.  This issue will involve fixing the genuine ones that are fixable in time for
0.4.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message