cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Greene (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-383) StorageProxy.insertBlocking does not perform hinted handoff
Date Fri, 21 Aug 2009 06:02:14 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745818#action_12745818
] 

Michael Greene commented on CASSANDRA-383:
------------------------------------------

I think this is what you'll want to do, getting rid of the temp counter.
{{{
EndPoint[] endPoints = (EndPoint[])endpointMap.keySet().toArray(new EndPoint[endpointMap.size()]);
}}}

It might be pedantic, but I also think we should be making the quorum calculation consistent,
instead of
availability style
{{{
(DatabaseDescriptor.getReplicationFactor() / 2) + 1)
}}}
versus blocking style
{{{
(DatabaseDescriptor.getReplicationFactor() >> 1) + 1)
}}}

Apart from these, looks good.

> StorageProxy.insertBlocking does not perform hinted handoff
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-383
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-383
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.4
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: 0.4
>
>         Attachments: 383-v1.patch, 383-v2.patch
>
>
> insertBlocking should use getNStorageEndPointMap (like insert) instead of just getNStorageEndPoint
so that it can perform hinted handoff.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message