cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jun Rao (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-332) Clean up SSTableSliceIterator to not echo data around DataOutput/Inputs
Date Thu, 06 Aug 2009 15:05:14 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740096#action_12740096
] 

Jun Rao commented on CASSANDRA-332:
-----------------------------------

1. Since both the first and the last column are always in the index, can't you just check
the firstcolumn? Column name takes more space than count. I'd rather not duplicate it in the
index entry.

2. If you check the Java doc, the insertionPoint can be collection.size() when the search
key is larger than the last element. When index==0 or index===indexList.size(), you can avoid
deserializing the column index since the searched column is guaranteed not to be found.


> Clean up SSTableSliceIterator to not echo data around DataOutput/Inputs
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-332
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-332
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.4
>
>         Attachments: 0001-CASSANDRA-332-add-test-for-multi-block-reversal.txt, 0002-don-t-serialize-unused-column-count-into-column-index.txt,
0003-always-write-indexes-for-at-least-first-and-last-colum.txt, 0004-move-comparator-out-of-IndexInfo.txt,
0005-avoid-copying-variables-to-ColumnGroupReader-that-it-c.txt, 0006-final-cleanup-of-SSTableSliceIterator-now-with-less-u.txt
>
>
> use CFSerializer.deserializeEmpty and then read the columns as necessary, similar to
what was done for SSTableNamesIterator

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message