cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-358) SystemTable.initMetadata throws an NPE when called twice
Date Tue, 11 Aug 2009 16:09:14 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741925#action_12741925
] 

Jonathan Ellis commented on CASSANDRA-358:
------------------------------------------

thanks for the patch!

the explanation is simple but how does taking care of state three double the existing code
size?  skimming the patch it looks like we might be overengineering things a bit here.  could
you split this into "cleanup" and "add functionality" patches?  it's much easier to follow
that way.  (then the review can skim the cleanup for sanity checking, and focus on reviewing
the new functionality.)

a couple style notes:

no underscore_ in variables is preferred.  if a class is mixed cleanup should convert to no-underscores.

avoid splitting methods up that are not reusable or perform a simple expression.  if a block
of code is used in only one place, prefer leaving it inline (use whitespace to denote logical
blocks, and comments if necessary).  obviously there are gray areas but methods like "notFound"
and "applyAddColumn" are definitely over the line.

> SystemTable.initMetadata throws an NPE when called twice
> --------------------------------------------------------
>
>                 Key: CASSANDRA-358
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-358
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jeff Hodges
>         Attachments: 358-4.patch
>
>
> While this is not the expected use case of it, SystemTable.initMetadata throws an NPE
when called twice in the same process.  The error points to tokenColumn being null even through
cf is not at line 111.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message