Mailing-List: contact cassandra-commits-help@incubator.apache.org;
 run by ezmlm
Precedence: bulk
Reply-To: cassandra-dev@incubator.apache.org
Message-ID: <2093556625.1246902914844.JavaMail.jira@brutus>
Date: Mon, 6 Jul 2009 10:55:14 -0700 (PDT)
From: "Jun Rao (JIRA)" <jira@apache.org>
To: cassandra-commits@incubator.apache.org
Subject: [jira] Commented: (CASSANDRA-277) combine _range slice methods into
 main ones
In-Reply-To: <1278721810.1246900034869.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727643#action_12727643 ] 

Jun Rao commented on CASSANDRA-277:
-----------------------------------

I am a bit concerned with parameter overloading here. In get_slice_by_name_range, we don't really need finish and count at the same time. How about just dropping count from get_slice_by_name_range?

> combine _range slice methods into main ones
> -------------------------------------------
>
>                 Key: CASSANDRA-277
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-277
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>
> Instead of
>   list<column_t> get_slice_by_name_range(1:string tablename, 2:string key, 3:string columnParent, 4:string start, 5:string finish, 6:i32 count=100)
>   throws (1: InvalidRequestException ire, 2: NotFoundException nfe),
>   
>   list<column_t> get_slice(1:string tablename, 2:string key, 3:string columnParent, 4:bool isAscending, 5:i32 count=100)
>   throws (1: InvalidRequestException ire, 2: NotFoundException nfe),
> we would just have
>   list<column_t> get_slice(tablename, key, columnParent, start, finish, isAscending, count=100)
> (note that get_slice currently has "start" arg folded into columnParent which is the wrong way to go for CASSANDRA-139 and also caused the CASSANDRA-260 regression, so breaking that back out seems like the Right Thing To Do.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.