cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-111) Mixed line endings in the codebase
Date Fri, 31 Jul 2009 12:34:15 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737511#action_12737511
] 

Hudson commented on CASSANDRA-111:
----------------------------------

Integrated in Cassandra #153 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/153/])
    run source files through dos2unix to standardize on \n line endings.  patch by Jeff Hodges;
reviewed by Michael Greene for 


> Mixed line endings in the codebase
> ----------------------------------
>
>                 Key: CASSANDRA-111
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-111
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Jeff Hodges
>            Assignee: Jeff Hodges
>             Fix For: 0.4
>
>         Attachments: 0001-unix-line-endings-everywhere-on-top-of-r797209.patch, 0001-unix-line-endings-on-799140.patch,
line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings.
Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file
endings and corrects them to Unix.
> Also attached is the program that I used to remove them. 
> Using Unix line endings in all places makes lots of things easier. At the very least,
a consistent choice of line endings would. Has there been discussion of what should be the
correct line ending to use?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message