cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Ribeiro (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-275) Replace Map.keySet by more efficient Map.entrySet
Date Tue, 07 Jul 2009 23:07:14 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728410#action_12728410
] 

Edward Ribeiro commented on CASSANDRA-275:
------------------------------------------

Really. Well, I propose to get rid of this patch altogether, but my previous comment is still
valid.

Some places of the code base look pretty bad. Anyone could get in charge of fixing these in
the future?

> Replace Map.keySet by more efficient Map.entrySet
> -------------------------------------------------
>
>                 Key: CASSANDRA-275
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-275
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Edward Ribeiro
>            Priority: Minor
>         Attachments: CASSANDRA-275.patch
>
>
> When you iterates over all key-values of a Map is better to use entrySet() instead of
a call to entryKey() and a call to get() inside the loop. It's more efficient. 
> I've seen a patch like this before, but I don't think it was applied at all. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message