cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Greene (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-174) reduce logging overhead
Date Wed, 29 Jul 2009 16:12:14 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736682#action_12736682
] 

Michael Greene commented on CASSANDRA-174:
------------------------------------------

> some of the debug() lines don't have the if statement

I don't think that's true.  Did you apply my patch?  I'm in agreement that all the paths should
be covered, I was just mentioning that the new patch happens to hit some important paths--it
should *cover* all paths though.

I just double-checked with:

grep --exclude="*.svn-base" -R -B 1 "\.debug" .

and I don't see anything.

> reduce logging overhead
> -----------------------
>
>                 Key: CASSANDRA-174
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-174
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Chris Goffinet
>            Priority: Critical
>             Fix For: 0.4
>
>         Attachments: 0001-Cleaned-up-logger_.debug-with-isDebugEnabled.patch, 0002-Cleaned-up-logger_.debug-with-isDebugEnabled.patch,
174_3.diff
>
>
> Logging overhead dominates workload for small column values.  This can be mitigated by
switching to INFO but you still have the overhead of throwing all those strings together.
 Some ideas here: http://surguy.net/articles/removing-log-messages.xml

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message