cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <>
Subject [jira] Commented: (CASSANDRA-330) encapsulate SequenceFile, AbstractWriter better
Date Fri, 31 Jul 2009 20:39:14 GMT


Jonathan Ellis commented on CASSANDRA-330:

    remove AbstractWriter. all it was providing was append methods, which are inlined into
SSTableWriter now; the res

    r/m SequenceFile. ColumnGroupReader moved to SSTableSliceIterator mostly unchanged for
now. (finish cleaning this

    replace with code in NamesIterator that doesn't rewrite data through an extra
layer of DataOutput/Input

    SF shouldn't duplicate position checking that was already done by SSTable.  move utility
methods to
    IndexHelper.  fix off-by-4 in dataSizeReturned.

    r/m code in handling being called multiple times, since it can only be called

    r/m special case that no column names=all columns; add test for no-columns cases

    r/m in favor of more-efficient IteratingRow

    move next, getColumnGroupReader out of SSTableReader

    make CommitLog use a raw BufferedRandomAccessFile instead of overloading AbstractWriter/IFileReader
    unnecessarily.  the set of AW features used by both CommitLog and SSTable was nil.

> encapsulate SequenceFile, AbstractWriter better
> -----------------------------------------------
>                 Key: CASSANDRA-330
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>         Attachments: 0001-CASSANDRA-330.txt, 0002-move-next-getColumnGroupReader-out-of-SSTableReader.txt,, 0004-r-m-special-case-that-no-column-names-all-columns-add.txt,, 0006-SF-shouldn-t-duplicate-position-checking-that-was-alre.txt,, 0008-r-m-SequenceFile.-ColumnGroupReader-moved-to-SSTableSl.txt,
> these two are just massive piles of encapsulation violation, duplicating code from CF/SC/C
serializers that make it very error prone to change serialization format.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message