cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Greene (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-111) Mixed line endings in the codebase
Date Fri, 03 Jul 2009 02:59:47 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726781#action_12726781
] 

Michael Greene commented on CASSANDRA-111:
------------------------------------------

I don't think it would handle them properly, although I'm not sure.  You can set individual
files to one or the other, or native, but I think you'd have to leave it without an svn:eol-style
if you *wanted* to keep it mixed.  It'd be better to convert them first if there's no compelling
reason for them to be mixed.

http://svnbook.red-bean.com/en/1.1/ch07s02.html#svn-ch-7-sect-2.3.5 is the relevant section
of the subversion book.

The algorithm would be:
 - find all files we want to have proper eol's
 - convert them all to your native system's eol's
 - for each filename in files:
 - - svn propset svn:eol-style native filename
 - commit all files

The above is obviously most easily done with a script.

To keep things nice going forward after this is done, if each committer added the following
section to their .subversion/config then new files would automatically have the correct eol
style set:
[auto-props]
*.java = svn:eol-style=native
*.properties = svn:eol-style=native
*.py= svn:eol-style=native
*.sh = svn:eol-style=native;svn:executable
*.thrift = svn:eol-style=native
*.txt = svn:eol-style=native
*.xml = svn:eol-style=native

> Mixed line endings in the codebase
> ----------------------------------
>
>                 Key: CASSANDRA-111
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-111
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jeff Hodges
>         Attachments: line_endings.patch, no.rb
>
>
> There seems to be a lot of line endings in the codebase that end with DOS line endings.
Some files are even mixes of DOS and Unix line endings. This patch removes all the DOS file
endings and corrects them to Unix.
> Also attached is the program that I used to remove them. 
> Using Unix line endings in all places makes lots of things easier. At the very least,
a consistent choice of line endings would. Has there been discussion of what should be the
correct line ending to use?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message