Return-Path: Delivered-To: apmail-incubator-cassandra-commits-archive@minotaur.apache.org Received: (qmail 84663 invoked from network); 11 Jun 2009 12:49:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 11 Jun 2009 12:49:23 -0000 Received: (qmail 94811 invoked by uid 500); 11 Jun 2009 12:49:34 -0000 Delivered-To: apmail-incubator-cassandra-commits-archive@incubator.apache.org Received: (qmail 94784 invoked by uid 500); 11 Jun 2009 12:49:34 -0000 Mailing-List: contact cassandra-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cassandra-dev@incubator.apache.org Delivered-To: mailing list cassandra-commits@incubator.apache.org Received: (qmail 94774 invoked by uid 99); 11 Jun 2009 12:49:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jun 2009 12:49:34 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jun 2009 12:49:32 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 8CFA2234C055 for ; Thu, 11 Jun 2009 05:49:12 -0700 (PDT) Message-ID: <667117543.1244724552576.JavaMail.jira@brutus> Date: Thu, 11 Jun 2009 05:49:12 -0700 (PDT) From: "Hudson (JIRA)" To: cassandra-commits@incubator.apache.org Subject: [jira] Commented: (CASSANDRA-218) exit if OOM occurs In-Reply-To: <28132722.1244215327339.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718431#action_12718431 ] Hudson commented on CASSANDRA-218: ---------------------------------- Integrated in Cassandra #105 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/105/]) system.exit on oome. patch by jbellis; reviewed by Eric Evans for > exit if OOM occurs > ------------------ > > Key: CASSANDRA-218 > URL: https://issues.apache.org/jira/browse/CASSANDRA-218 > Project: Cassandra > Issue Type: Improvement > Reporter: Jonathan Ellis > Assignee: Jonathan Ellis > Attachments: 218.patch > > > The drawbacks to continuing running (generating internal errors in strange places) outweigh the benefits (maybe having the thread that OOM'd freed will allow us to serve some other requests successfully). > I'm guessing that adding if (e instanceof OOME) { system.exit() } in our DefaultUncaughtExceptionHandler would do the trick. > Only question is, would that happen before or after the XX:+HeapDumpOnOutOfMemoryError gets to fire? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.