Mailing-List: contact cassandra-commits-help@incubator.apache.org;
 run by ezmlm
Precedence: bulk
Reply-To: cassandra-dev@incubator.apache.org
Message-ID: <1243585495.1245552007333.JavaMail.jira@brutus>
Date: Sat, 20 Jun 2009 19:40:07 -0700 (PDT)
From: "Edward Ribeiro (JIRA)" <jira@apache.org>
To: cassandra-commits@incubator.apache.org
Subject: [jira] Commented: (CASSANDRA-248) Replace factory method based on
 explicit locks for a more succint syntax
In-Reply-To: <1239708237.1245549367351.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722293#action_12722293 ] 

Edward Ribeiro commented on CASSANDRA-248:
------------------------------------------

I agree that doing DCL is faster, but it increases the complexity of a simple method and make it more error prone, imho. In addition, I don't know if the performance gain is really substancial in this case. Therefore, a bit slower, but simpler, method can improve the maintainability in the mid term.

I'll take a look at other instance() implementations of the code base to implement a one single patch.

> Replace factory method based on explicit locks for a more succint syntax
> ------------------------------------------------------------------------
>
>                 Key: CASSANDRA-248
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-248
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Edward Ribeiro
>         Attachments: CASSANDRA-248.patch
>
>
> Replace factory method based on explicit locks for a more succint syntax. The code becomes simpler and more readable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.