cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jun Rao (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-202) Refactor different getRow calls in Table.java to more specific name and add more logging information
Date Mon, 01 Jun 2009 16:43:07 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715146#action_12715146
] 

Jun Rao commented on CASSANDRA-202:
-----------------------------------

Now that we have to use different names in thrift, wouldn't using those same names internally
make things clearer for development purpose? Otherwise, a developer is forced to remember
the name mapping.

On the surface, arguments other than key and CF won't trigger IOExceptions. However, they
can trigger IOExceptions indirectly. For example, for the get_slice_by_names call, depending
on the list of columns provided, we may need to open different set of SSTables.  Therefore,
for debugging purpose, it is useful to know the exact parameters that triggered the exceptions.


> Refactor different getRow calls in Table.java to more specific name and add more logging
information
> ----------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-202
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-202
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>         Attachments: issue202.patchv1, issue202.patchv2
>
>
> The Table class has five different getRow methods. We need to change them to more appropriate
names. Also, when an IOException occurs, it would be useful to log the parameters of the request.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message