cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-214) Incorrect parameter names in Thrift interface
Date Thu, 04 Jun 2009 21:21:07 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716408#action_12716408
] 

Jonathan Ellis commented on CASSANDRA-214:
------------------------------------------

we ought to be able to do better than that in the code w/ overloaded methods that each have
a real signature where a string is a string not two connected with a colon :)

> Incorrect parameter names in Thrift interface
> ---------------------------------------------
>
>                 Key: CASSANDRA-214
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-214
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.3
>            Reporter: Thorsten von Eicken
>            Assignee: Jonathan Ellis
>            Priority: Minor
>         Attachments: 214.patch
>
>
> The Thrift interface is incorrect as follows. This does not affect correctnes, it just
makes it hard to understand the operations.
> The Thrift interface for get_superColumn is incorrect. It seems to me that "3:string
columnFamily" should really be "3:string columnFamily_superColumnName" (I know this doesn't
have any functional impact, just makes it hard to understand what the operation does)
> The Thrift interface for get_slice_super is incorrect. It seems to me that "3:string
columnFamily_superColumnName" should really be "3:string columnFamily"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message