cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-228) Improve the readability of the DBManager.instance() method
Date Tue, 16 Jun 2009 12:35:08 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720100#action_12720100
] 

Hudson commented on CASSANDRA-228:
----------------------------------

Integrated in Cassandra #110 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/110/])
    switch singleton implementation from double-checked-locking to synchronized (code is not
performance-sensitive).  patch by Edward Ribeiro; reviewed by jbellis for 


> Improve the readability of the DBManager.instance() method
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-228
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-228
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Edward Ribeiro
>            Assignee: Edward Ribeiro
>         Attachments: CASSANDRA-228.patch
>
>
> The DBManager class implements the singleton pattern using a Lock object, but it could
replace the Lock object by declaring the instance() method as synchronized. Therefore, it
avoids the race condition (as with Lock), but improves the readability and reduces the size
of the method. Below is the new version of the method:
> 	public static synchronized DBManager instance() throws IOException
> 	{
> 		if (dbMgr_ == null)
> 			dbMgr_ = new DBManager();
> 		return dbMgr_;
> 	}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message