cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Ribeiro (JIRA)" <j...@apache.org>
Subject [jira] Created: (CASSANDRA-228) Improve the readability of the DBManager.instance() method
Date Sun, 14 Jun 2009 14:50:07 GMT
Improve the readability of the DBManager.instance() method
----------------------------------------------------------

                 Key: CASSANDRA-228
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-228
             Project: Cassandra
          Issue Type: Improvement
            Reporter: Edward Ribeiro


The DBManager class implements the singleton pattern using a Lock object, but it could replace
the Lock object by declaring the instance() method as synchronized. Therefore, it avoids the
race condition (as with Lock), but improves the readability and reduces the size of the method.
Below is the new version of the method:

	public static synchronized DBManager instance() throws IOException
	{
		if (dbMgr_ == null)
			dbMgr_ = new DBManager();
		return dbMgr_;
	}


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message