cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Ribeiro (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-248) Replace factory method based on explicit locks for a more succint syntax
Date Sun, 21 Jun 2009 02:40:07 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722293#action_12722293
] 

Edward Ribeiro commented on CASSANDRA-248:
------------------------------------------

I agree that doing DCL is faster, but it increases the complexity of a simple method and make
it more error prone, imho. In addition, I don't know if the performance gain is really substancial
in this case. Therefore, a bit slower, but simpler, method can improve the maintainability
in the mid term.

I'll take a look at other instance() implementations of the code base to implement a one single
patch.

> Replace factory method based on explicit locks for a more succint syntax
> ------------------------------------------------------------------------
>
>                 Key: CASSANDRA-248
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-248
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Edward Ribeiro
>         Attachments: CASSANDRA-248.patch
>
>
> Replace factory method based on explicit locks for a more succint syntax. The code becomes
simpler and more readable.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message