cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-224) Encapsulate SSTable, SequenceFile better
Date Wed, 24 Jun 2009 14:37:07 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723580#action_12723580
] 

Hudson commented on CASSANDRA-224:
----------------------------------

Integrated in Cassandra #118 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/118/])
    make static methods of SSTable that take a filename and then use the cache to grab an
sstable object, simple non-static methods instead
patch by jbellis; reviewed by Eric Evans for 
encapsulate sstable bloom filter
patch by jbellis; reviewed by Eric Evans for 
encapsulate sstable index
patch by jbellis; reviewed by Eric Evans for 
refactor read-only constructor to SSTable.open
patch by jbellis; reviewed by Eric Evans for 
r/m unused code dealing with sstables, and ConcurrentWriter / FastConcurrentWriter.  mmap
is not faster than write() for sequential I/O, which is what the vast majority of our writes
are.  mmap _does_ have an advantage when we seek back to the start of a commitlog segment
to update the headers after memtable flush, but we do that infrequently enough that it's not
worth the disadvantages (primarily, blowing up if we exceed the 4MB size).
patch by jbellis; reviewed by Eric Evans for 


> Encapsulate SSTable, SequenceFile better
> ----------------------------------------
>
>                 Key: CASSANDRA-224
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-224
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.4
>
>         Attachments: 0001-CASSANDRA-224-r-m-unused-code-dealing-with-sstables-a.txt,
0002-refactor-read-only-constructor-to-SSTable.open.txt, 0003-encapsulate-index.txt, 0004-encapsulate-bloom-filter.txt,
0005-make-static-methods-of-SSTable-that-take-a-filename-an.txt
>
>
> All kinds of code needs to know about the inner workings of SSTable to work.  A major
cause is passing around SSTable filenames instead of objects.  Thanks to CASSANDRA-208 I feel
like I have a good enough understanding of the code here to refactor more than superficially.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message