cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evan Weaver (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-266) Thrift validation bugs
Date Tue, 30 Jun 2009 22:00:48 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725828#action_12725828
] 

Evan Weaver commented on CASSANDRA-266:
---------------------------------------

Looks ok except for two issues:

* validateColumnPathOrParent has no callpoints.

* in validateColumnPathOrParent,
   +        else if (values.length != 3)
  should be
  +        else if (values.length > 3)


> Thrift validation bugs
> ----------------------
>
>                 Key: CASSANDRA-266
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-266
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Evan Weaver
>            Assignee: Jonathan Ellis
>         Attachments: 266.patch
>
>
> Server does not raise on invalid insert into regular ColumnFamily
> DEBUG - Applying RowMutation(table='Twitter', key='8', modifications=[ColumnFamily(Statuses
[body:false:5@1246336092])])
> DEBUG - RowMutation(table='Twitter', key='8', modifications=[ColumnFamily(Statuses [body:false:5@1246336092])])
applied. 
> OK
> DEBUG - Applying RowMutation(table='Twitter', key='8', modifications=[ColumnFamily(Statuses
[fhwagads:body:false:5@1246336111])])
> DEBUG - RowMutation(table='Twitter', key='8', modifications=[ColumnFamily(Statuses [fhwagads:body:false:5@1246336111])])
applied.  
> Not ok... "Statuses:fhwagads:body" insert should have failed. For example:
> java.lang.IllegalArgumentException: Column Family Statuses:fhwagads:fhwagads:body in
invalid format. Must be in <column family>:<column> format.
> Also:
> You can request an array of values via get_slice_by_names, and you can request an array
of columns via get_super_slice_by_names, but you can't request an array of values through
a supercolumn via either one. "Ideally" get_slice_by_names should allow a supercolumn specification
like below:
> InvalidRequestException: Column Family StatusRelationships:user_timelines is invalid.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message