cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Johan Oskarsson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-164) Fix junit related build issues
Date Wed, 13 May 2009 14:59:45 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708959#action_12708959
] 

Johan Oskarsson commented on CASSANDRA-164:
-------------------------------------------

I know we are not going to agree on this, but wanted to throw it out there anyway.

I didn't mean that you as a committer should upload a new, revised patch, that would be quite
a workload. Instead what I was suggesting was that you suggest the changes needed in the ticket,
wait for the developer to either submit a new patch or discuss your suggested changes. 

It's not that I don't trust your code changes. The main reason is that imho the latest patch
in jira should be the one applied to svn for a few reasons, transparency being one and from
my experience it is very helpful for power users to be able to download the patch and apply
it to older versions of the software. We do this all the time at Last.fm with our Hadoop installation.

I'm not going to push this further, just wanted it said.

> Fix junit related build issues
> ------------------------------
>
>                 Key: CASSANDRA-164
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-164
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.3
>            Reporter: Johan Oskarsson
>            Assignee: Johan Oskarsson
>             Fix For: 0.3
>
>         Attachments: CASSANDRA-164.patch
>
>
> Since the junit switch no xml report files are generated and the build doesn't fail properly
if a test fails

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message