cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-202) Refactor different getRow calls in Table.java to more specific name and add more logging information
Date Thu, 28 May 2009 21:33:47 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714187#action_12714187
] 

Jonathan Ellis commented on CASSANDRA-202:
------------------------------------------

Adding key/cf info to the IOExceptions is a good thing, but it should be added to the IOException
message instead of logging a separate debug before the error, and it should be done where
the actual IOE comes from, not in the ex-getRow calls (which is overly broad, we should only
add key/cf info to IOEs that actually involve the key, e.g. SF.next, not SSTable.init or bufIn.readUTF()
-- or we muddy the water instead of clarifying it.

> Refactor different getRow calls in Table.java to more specific name and add more logging
information
> ----------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-202
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-202
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>         Attachments: issue202.patchv1
>
>
> The Table class has five different getRow methods. We need to change them to more appropriate
names. Also, when an IOException occurs, it would be useful to log the parameters of the request.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message