cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Updated: (CASSANDRA-159) avoid repetetive sorting in CFS.getColumnFamilyFromDisk
Date Tue, 12 May 2009 15:49:45 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Ellis updated CASSANDRA-159:
-------------------------------------

    Attachment: 0002-CASSANDRA-159-fix-race-condition-between-when-memtable.txt
                0001-extract-tests-that-could-conflict-with-each-other-to-a.txt

> avoid repetetive sorting in CFS.getColumnFamilyFromDisk
> -------------------------------------------------------
>
>                 Key: CASSANDRA-159
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-159
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>             Fix For: 0.4
>
>
> getColumnFamilyFromDisk starts out with
>         List<String> files = new ArrayList<String>();        
>     	lock_.readLock().lock();
>         try
>         {
>             files.addAll(ssTables_);
>             Collections.sort(files, new FileNameComparator(FileNameComparator.Descending));
>         }
>         finally
>         {
>             lock_.readLock().unlock();
>         }
> this is silly, we should really keep the list sorted instead of re-sorting for *each*
*read*.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message