cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <>
Subject [jira] Updated: (CASSANDRA-163) fix RackUnawareStrategyTest
Date Tue, 12 May 2009 21:35:45 GMT


Jonathan Ellis updated CASSANDRA-163:

    Comment: was deleted

(was: here is the problem

    void put(String key, ColumnFamily columnFamily, CommitLog.CommitLogContext cLogCtx) throws
        isDirty_ = true;
        executor_.submit(new Putter(key, columnFamily));
        if (isThresholdViolated())

(enqueueFlush is the one that swaps out this memtable for a new one in CFS and calls shutdown)

the problem is that we submit first and ask questions later, so we can clearly submit to this
[old] memtable on one thread after another thread starts the shutdown.

the only option I see is going to back to the old double-checked-ish logic of checking threshold
first, then recursing to resubmit if we switch memtables.  (overriding TPE.execute/addIfUnderMaximumPoolSize
is not an option since liberal use of private variables is made.))

> fix RackUnawareStrategyTest
> ---------------------------
>                 Key: CASSANDRA-163
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
> it's been failing for forever but it was in the wrong directory so testng didn't run
it.  I've moved it to the right directory for the junit migration but commented out.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message