cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-164) Fix junit related build issues
Date Wed, 13 May 2009 14:51:45 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708955#action_12708955
] 

Jonathan Ellis commented on CASSANDRA-164:
------------------------------------------

> I wish you wouldn't commit patches with additional, non reviewed changes

Refrain from judgement for a moment and let's look at how the workflow compares.

Without taking shortcuts:

If my change is good:

1) original patch uploaded
2) my patch uploaded
3) my patch approved
4) commit

If my change is not good:

1) original patch uploaded
2) my patch uploaded
3) new patch from reviewer
4) commit

(obviously repeat 2-3 as necessary, let's keep things simple though).

Now, with shortcuts:

If my change is good:

1) original patch uploaded
2) commit patch w/ my changes

If my change is not good:

1) original patch uploaded
2) commit patch w/ my changes
3) new patch from reviewer against my commit
4) commit new patch

So in the case where my change is not good, we have basically the same steps and our only
loss is an extra svn commit at step 2.

But when my change _is_ good we cut the steps where someone is waiting on someone else in
half.

That seems like the risk is worth it to me.  (And my track record is very good here; I can't
remember ever making a change that the author/reviewer disagreed with.  Part of that is if
I make a nontrivial change I do in fact upload patches first.)

> Fix junit related build issues
> ------------------------------
>
>                 Key: CASSANDRA-164
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-164
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.3
>            Reporter: Johan Oskarsson
>            Assignee: Johan Oskarsson
>             Fix For: 0.3
>
>         Attachments: CASSANDRA-164.patch
>
>
> Since the junit switch no xml report files are generated and the build doesn't fail properly
if a test fails

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message