Return-Path: Delivered-To: apmail-incubator-cassandra-commits-archive@minotaur.apache.org Received: (qmail 26608 invoked from network); 22 Apr 2009 17:01:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 22 Apr 2009 17:01:11 -0000 Received: (qmail 96733 invoked by uid 500); 22 Apr 2009 17:01:11 -0000 Delivered-To: apmail-incubator-cassandra-commits-archive@incubator.apache.org Received: (qmail 96705 invoked by uid 500); 22 Apr 2009 17:01:11 -0000 Mailing-List: contact cassandra-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cassandra-dev@incubator.apache.org Delivered-To: mailing list cassandra-commits@incubator.apache.org Received: (qmail 96691 invoked by uid 99); 22 Apr 2009 17:01:11 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Apr 2009 17:01:11 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Apr 2009 17:01:09 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 738BB234C003 for ; Wed, 22 Apr 2009 10:00:47 -0700 (PDT) Message-ID: <2009524221.1240419647462.JavaMail.jira@brutus> Date: Wed, 22 Apr 2009 10:00:47 -0700 (PDT) From: "Jonathan Ellis (JIRA)" To: cassandra-commits@incubator.apache.org Subject: [jira] Commented: (CASSANDRA-14) The initial arrive time should not be set to zero MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CASSANDRA-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701600#action_12701600 ] Jonathan Ellis commented on CASSANDRA-14: ----------------------------------------- part 2 cleans up FD by using a Deque instead of a List. > The initial arrive time should not be set to zero > ------------------------------------------------- > > Key: CASSANDRA-14 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14 > Project: Cassandra > Issue Type: Bug > Reporter: zhu han > Assignee: Avinash Lakshman > Fix For: 0.3 > > Attachments: 14-part-2.patch, 14.patch > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > In line 253 of src.org.apache.cassandra.gms .FailureDetector, the initial arrive time should not be zero. Otherwise, the failure detector would report the new joining node as dead because the phi is positive infinity when the mean of arrive time is zero. > A proper value should be set as the initial value. I use half of the gossip period as the initial value, whose default configuration is 1000ms. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.