Mailing-List: contact cassandra-commits-help@incubator.apache.org;
 run by ezmlm
Precedence: bulk
Reply-To: cassandra-dev@incubator.apache.org
Message-ID: <1774886507.1239839594818.JavaMail.jira@brutus>
Date: Wed, 15 Apr 2009 16:53:14 -0700 (PDT)
From: "Sandeep Tata (JIRA)" <jira@apache.org>
To: cassandra-commits@incubator.apache.org
Subject: [jira] Commented: (CASSANDRA-84) Bug removing supercolumn
In-Reply-To: <1868872403.1239815774859.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699453#action_12699453 ] 

Sandeep Tata commented on CASSANDRA-84:
---------------------------------------

Looks good to me.

Nits:
1. I'd rather use  !columnFamily.isSuper() instead of DatabaseDescriptor.getColumnFamilyType(cfName).equals("Standard")
2. Messages from testng assertions seem a little friendlier than plain java assertions.


> Bug removing supercolumn
> ------------------------
>
>                 Key: CASSANDRA-84
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-84
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.3
>
>         Attachments: 0001-make-remove-test-code-use-the-same-api-that-the-thri.patch, 0002-generate-supercolumn-tombstone-when-a-2-tuple-delete.patch
>
>
> The code to create a SuperColumn tombstone has a bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.