cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Evans (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-88) clean up CassandraServer and StorageProxy
Date Mon, 20 Apr 2009 18:21:47 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700888#action_12700888
] 

Eric Evans commented on CASSANDRA-88:
-------------------------------------

This looks pretty good to me, with the exception of a few classes in org.apache.cassandra.cql
which didn't get updated. +1 provided that 0001-update-cql-classes-for-StorageProxy.readProtocol-int.txt
(or something comparable) is applied.

(Sorry about the poor naming of the patch I attached.)


> clean up CassandraServer and StorageProxy
> -----------------------------------------
>
>                 Key: CASSANDRA-88
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-88
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.3
>
>         Attachments: 0001-CASSANDRA-88-rename-get_cf-readColumnFamily-ReadMe.txt, 0001-update-cql-classes-for-StorageProxy.readProtocol-int.txt,
0002-clean-up-ReadCommand-it-s-basically-a-struct-so-use-p.txt, 0002-v2.patch, 0002-v3.patch,
0003-rename-ReadResponseMessage-ReadResponse.txt, 0004-refactor-read-path-first-we-make-readColumnFamily-acc.txt,
0004-v3.patch
>
>
> there is a ton of duplicate code here that makes it difficult to improve the thrift interface

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message