cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-77) Need RangeFilter that filters by column name so that min <= name <= max
Date Tue, 14 Apr 2009 00:58:14 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698604#action_12698604
] 

Todd Lipcon commented on CASSANDRA-77:
--------------------------------------

- I don't know how Filters interact with the rest of the system very well, but isDone_ is
currently always false. If it's a constant, you should skip the member variable. Otherwise,
it should turn true somewhere.
- I'd like to see colMin_ and colMax_ declared final, since they are never mutated.
- The code implements colmin <= colname <= colmax, but the javadoc indicates colmin
< colname < colmax
- @author tags are looked down upon by the ASF
- There's no Apache 2.0 license header
- In the unit test, you should use assertNull, assertNotNull, etc. from org.testng.Assert
rather than Java assertions. This provides for more informative error messages.

> Need RangeFilter that filters by column name so that min <= name <= max
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-77
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-77
>             Project: Cassandra
>          Issue Type: Sub-task
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>
>         Attachments: rangefilter_and_tests.txt
>
>
> We need a filter much like CountFilter and TimeFilter to satisfy mincolname <= colname
<= maxcolname.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message