cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jun Rao (JIRA)" <j...@apache.org>
Subject [jira] Created: (CASSANDRA-95) clean up ReadCommand and related stuff for read repairs
Date Wed, 22 Apr 2009 22:26:47 GMT
clean up ReadCommand and related stuff for read repairs
-------------------------------------------------------

                 Key: CASSANDRA-95
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-95
             Project: Cassandra
          Issue Type: Improvement
            Reporter: Jun Rao
            Assignee: Jun Rao


Today, ReadCommand doesn't have an explicit type attribute. A specific type of ReadCommand
is determined based on subtle difference in parameters set.  For example:
        if (start > 0 || (count > 0 && count < Integer.MAX_VALUE))
        {
            return table.getRow(key, columnFamilyColumn, start, count);
        }
A get_slice ReadCommand is determined based on start and count values. This is very hard to
understand. Also, code like that is duplicated in ReadCommand and ConsistencyManager.

We need to make it easier to determine the type of a ReadCommand. This is necessary for code
maintenance as well as supporting new APIs in the future.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message