cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-65) Support for non-hash based partitioners
Date Thu, 09 Apr 2009 01:25:12 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697355#action_12697355
] 

Jonathan Ellis commented on CASSANDRA-65:
-----------------------------------------

Argh, Jira let me throw away my reply when I clicked on a link to doublecheck something. :(
 Here goes again.

1. If we need it later we can resurrect it from svn.  Dead code is more confusing than useful.

2. We probably need a better name here -- the idea is "generate a token that can be assigned
as the default for this node's endpoint if it starts up without having one configured."  How
about getInitialToken?

3. It just allows passing a single Token w/o explicitly wrapping it in an array (the compiler
does it for you).  IIRC I made use of this somewhere.

4. It's already in a unit test, in SystemTableTest.  My bad for not removing the main() method
earlier.

5. Yes, that will be in another patch.

6. Good question -- that method is only used by the status tool.  So the question is what
value to display when there is no token matching the endpoint.  "0" is potentially confusing
since it's a legitimate token value.  Empty string leaves no doubt that there is no token.
 I can add a comment to this effect.

> Support for non-hash based partitioners
> ---------------------------------------
>
>                 Key: CASSANDRA-65
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-65
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>         Attachments: 0001-CASSANDRA-65-move-Partitioner-from-cassandra.service.txt, 0002-r-m-unused-code.txt,
0003-clean-up-partition-strategies-in-particular-implemen.txt, 0004-replace-BigInteger-tokens-with-BigIntegerToken-and-Str.txt,
0005-r-m-StorageService.token-in-favor-of-explicitly-pass.patch, 0006-add-test-for-ReplicaPlacementStrategy-covering-both.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message