cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sandeep Tata (JIRA)" <>
Subject [jira] Updated: (CASSANDRA-77) Need RangeFilter that filters by column name so that min <= name <= max
Date Tue, 14 Apr 2009 04:37:15 GMT


Sandeep Tata updated CASSANDRA-77:

    Attachment: rangefilter_and_tests_v2.txt

Thanks for the comments Todd.
>- I don't know how Filters interact with the rest of the system very well, but isDone_
is currently always false. If it's a constant, you should skip the member variable. Otherwise,
it should turn true somewhere. 

isDone_ should always be false when you only specify a min and a max, you can't tell that
you're done until you've processed all the ssTables. I've modified the filter to also accept
a max-count argument. If provided, the filter is done once it has filtered count columns.
If count is not provided initially, then the behavior is as before, the filter is not done
until all ssTables are processed.

>- I'd like to see colMin_ and colMax_ declared final, since they are never mutated. 

>- The code implements colmin <= colname <= colmax, but the javadoc indicates colmin
< colname < colmax 
Fixed javadoc.

>- @author tags are looked down upon by the ASF 

- There's no Apache 2.0 license header 

- In the unit test, you should use assertNull, assertNotNull, etc. from org.testng.Assert
rather than Java assertions. This provides for more informative error messages.

> Need RangeFilter that filters by column name so that min <= name <= max
> -----------------------------------------------------------------------
>                 Key: CASSANDRA-77
>                 URL:
>             Project: Cassandra
>          Issue Type: Sub-task
>    Affects Versions: trunk
>         Environment: all
>            Reporter: Sandeep Tata
>            Assignee: Sandeep Tata
>             Fix For: trunk
>         Attachments: rangefilter_and_tests.txt, rangefilter_and_tests_v2.txt
> We need a filter much like CountFilter and TimeFilter to satisfy mincolname <= colname
<= maxcolname.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message