cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jun Rao (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CASSANDRA-67) Review uses of FileStruct to make sure they are using decorated or raw keys correctly
Date Thu, 09 Apr 2009 19:08:12 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697607#action_12697607
] 

Jun Rao commented on CASSANDRA-67:
----------------------------------

FileStructIterator seems unnecessary. It seems it's better to fold what's in FileStructIterator
to FileStruct itself.

> Review uses of FileStruct to make sure they are using decorated or raw keys correctly
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-67
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-67
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>         Attachments: 67-v2.patch, 67-v3.patch, 67-v4.patch, 67.patch
>
>
> Jun Rao commented in #58,
> The problem is that FileStruct.key_ is referenced directly in 4 places. At least 2 of
those places assume key_ to be the real key, instead of decorated key. These 2 places are
in
> ColumnFamilyStore.doFileAntiCompaction() (key_ is assigned to lastkey, which is used
in isKeyInRanges)
> ColumnFamilyStore.doFileCompaction()
> In the above places, key_ has to be undeocrated first. Also, we need to make key_ private
in FileStruct and use getKey() for referencing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message