carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [carbondata] jackylk commented on a change in pull request #3586: [CARBONDATA-3668] CarbonSession should use old flow (non-CarbonExtensions flow)
Date Tue, 04 Feb 2020 12:57:21 GMT
jackylk commented on a change in pull request #3586: [CARBONDATA-3668] CarbonSession should
use old flow (non-CarbonExtensions flow)
URL: https://github.com/apache/carbondata/pull/3586#discussion_r374654461
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala
 ##########
 @@ -28,70 +28,63 @@ import org.apache.carbondata.common.logging.LogServiceFactory
 import org.apache.carbondata.core.util.CarbonProperties
 import org.apache.carbondata.spark.util.CarbonSparkUtil
 
- /**
-  * CarbonThriftServer support different modes:
-  * 1. read/write data from/to HDFS or local,it only needs configurate storePath
-  * 2. read/write data from/to S3, it needs provide access-key, secret-key, s3-endpoint
-  */
+/**
+ * CarbonThriftServer support different modes:
+ * 1. read/write data from/to HDFS or local, no need parameters
 
 Review comment:
   ```suggestion
    * 1. read/write data from/to HDFS or local, no parameter is required in this case
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message