From issues-return-34725-archive-asf-public=cust-asf.ponee.io@carbondata.apache.org Thu Feb 8 06:15:58 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 17BCE18065B for ; Thu, 8 Feb 2018 06:15:58 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 079D3160C5C; Thu, 8 Feb 2018 05:15:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4D0DC160C5B for ; Thu, 8 Feb 2018 06:15:57 +0100 (CET) Received: (qmail 7671 invoked by uid 500); 8 Feb 2018 05:15:56 -0000 Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.apache.org Delivered-To: mailing list issues@carbondata.apache.org Received: (qmail 7658 invoked by uid 99); 8 Feb 2018 05:15:56 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Feb 2018 05:15:56 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 417FDDF9FD; Thu, 8 Feb 2018 05:15:56 +0000 (UTC) From: SangeetaGulia To: issues@carbondata.apache.org Reply-To: issues@carbondata.apache.org Message-ID: Subject: [GitHub] carbondata pull request #1950: [CARBONDATA-2145] Refactored PreAggregate fun... Content-Type: text/plain Date: Thu, 8 Feb 2018 05:15:56 +0000 (UTC) GitHub user SangeetaGulia opened a pull request: https://github.com/apache/carbondata/pull/1950 [CARBONDATA-2145] Refactored PreAggregate functionality for dictionary include Description: Add the count to measure column only when the column is dictionary type in maintable. Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [x] Any interfaces changed? No - [x] Any backward compatibility impacted? No - [x] Document update required? No - [x] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? Ran already wriiten Unit Test case to test the functionality. Added Unit Test Case to check count on string type. - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. (N/A) You can merge this pull request into a Git repository by running: $ git pull https://github.com/SangeetaGulia/incubator-carbondata refactoringPreAgg Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/1950.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1950 ---- commit 576eb2e8997420125e90afbf85b37ca9cf9429ef Author: SangeetaGulia Date: 2018-02-07T08:15:29Z Refactored code for encodings when dictionary_include is present commit 71ab2208aa0a45b9504f6dd92111145b23d5f996 Author: SangeetaGulia Date: 2018-02-07T08:16:11Z Added test case on preAggregate for string type with count as aggregate function ---- ---